Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement window.atob/btoa #3082
Merged
Conversation
hoppipolla-critic-bot
commented
Aug 13, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2346 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Manishearth
added a commit
that referenced
this pull request
Aug 19, 2014
Implement window.atob/btoa; r=Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ChrisParis commentedAug 13, 2014
This provides functionality required in #3020. The implementation uses serialize::base64, but some preprocessing is required in order to match the HTML spec and pass the wpt tests. It's possible to improve efficiency by performing the extra work inline, within the serialize::base64 implementation, if it's desireable to change the standard library to match the web spec. For now, here's an implementation that passes the wpt tests and uses the Rust library as it is today.