Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement GetCaption and SetCaption for HTMLTableElement #3098

Merged
merged 1 commit into from Aug 16, 2014

Conversation

@ajnirp
Copy link
Contributor

ajnirp commented Aug 16, 2014

Fixes #3052

@highfive
Copy link

highfive commented Aug 16, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Aug 16, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2373

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Manishearth added a commit that referenced this pull request Aug 16, 2014
implement GetCaption and SetCaption for HTMLTableElement; r=Manishearth
@Manishearth Manishearth merged commit e9608a6 into servo:master Aug 16, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Manishearth
Copy link
Member

Manishearth commented Aug 16, 2014

Merged, congrats on your first patch!

If you want something similar, try out createCaption() and deleteCaption(), or some of the other table methods. There are also some "less easy" bugs here, though many of those might require python codegen changes.

Next time, don't do that merge in the middle of the review. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.