layout: return None bounding box when no nodes found #31253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HTMLImageElement.prototype.width/heightattributes should provide the rendered width/height of images that are being rendered, and the natural width/height of images that are not being rendered. In Servo, these attributes callbounding_content_boxon the node, treatingNoneas an indication that the element is not being rendered (and returning the natural width/height). But Layout 2020 returns a 0x0 bounding box for elements that are not being rendered, instead ofNone.As a result:
always gets 0/0 for the width/height (instead of the natural width/height) in Layout 2020.
This PR makes it so requests to Layout 2020 for the bounding box of a node that isn't being rendered return
Noneinstead of a 0x0 bounding box, which matches the Layout 2013 behavior../mach build -ddoes not report any errors./mach test-tidydoes not report any errors