Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upreturn null from GetNamespaceURI, not the empty string #3145
Conversation
hoppipolla-critic-bot
commented
Aug 25, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2442 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Aug 25, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
|
r+, waiting for Travis. In the meantime, it might be interesting to try and find out why the tagName test failed and solve that too :) |
|
@wenderen, I pointed out some now-passing tests on critic, and picked a few small nits while I was there. Thanks for your PR! |
|
@wenderen, can you please squash the four commits and force-push, so I can merge? Thanks! |
|
Dumb question: I just need to do |
|
Yep. |
correctly mark tests
return null from GetNamespaceURI, not the empty string; r=Manishearth, Ms2ger
ajnirp commentedAug 25, 2014
Fixes #3140
I tried changing the ini file for the Document-createElementNS.html test. I expected that changing the last three tests (the null / undefined / empty string namespace ones) to PASS would work, but apparently the tagName assert makes them fail. I guess that's a separate issue, so I left the ini file as it was.