Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase element.tagName for HTML elements only #3147

Merged
merged 1 commit into from Aug 28, 2014

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 25, 2014

Fixes #3146

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Aug 25, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2443

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Aug 26, 2014

 3:16.24 TEST_START: Thread-TestrunnerManager-3 /dom/nodes/Element-tagName.html

3:16.46 TEST_END: Thread-TestrunnerManager-3 Harness OK. Subtests passed 1/3. Unexpected 1

tagName should not upper-case for SVG elements in HTML documents.

-----------------------------------------------------------------

Expected FAIL, got PASS
 2:23.05 TEST_START: Thread-TestrunnerManager-3 /dom/nodes/Document-createElementNS.html

2:23.28 TEST_END: Thread-TestrunnerManager-3 Harness OK. Subtests passed 31/39. Unexpected 3

Lower-case non-HTML element without a prefix

--------------------------------------------

Expected FAIL, got PASS

Lower-case non-HTML element with a prefix

-----------------------------------------

Expected FAIL, got PASS

Upper-case non-HTML element with a prefix

-----------------------------------------

Expected FAIL, got PASS
@jdm
Copy link
Member

jdm commented Aug 26, 2014

failures:
/home/travis/build/servo/servo/src/test/content/test_document_body.html
/home/travis/build/servo/servo/src/test/content/test_document_head.html
@Manishearth
Copy link
Member

Manishearth commented Aug 27, 2014

#3145 merged, needs an update-wpt

@mbrubeck mbrubeck force-pushed the mbrubeck:tagname-upper branch from 4ca2b02 to 37dfb42 Aug 27, 2014
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Aug 28, 2014

The test failure appears to be an unrelated intermittent failure; filed #3180.

@mbrubeck mbrubeck force-pushed the mbrubeck:tagname-upper branch from c581826 to e015698 Aug 28, 2014
mbrubeck added a commit that referenced this pull request Aug 28, 2014
Uppercase element.tagName for HTML elements only r=Ms2ger
@mbrubeck mbrubeck merged commit 49765d2 into servo:master Aug 28, 2014
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
@mbrubeck mbrubeck deleted the mbrubeck:tagname-upper branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.