Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete TODO comments #3160

Merged
merged 1 commit into from Aug 26, 2014
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -123,7 +123,6 @@ impl TextRunScanner {

let font_style = old_fragment.font_style();

// TODO(#115): Use the actual CSS `white-space` property of the relevant style.
let compression = match old_fragment.white_space() {
white_space::normal => CompressWhitespaceNewline,
white_space::pre => CompressNone,
@@ -168,7 +167,6 @@ impl TextRunScanner {
let font_style = in_fragment.font_style();
let fontgroup = font_context.get_layout_font_group_for_style(&font_style);

// TODO(#115): Use the actual CSS `white-space` property of the relevant style.
let compression = match in_fragment.white_space() {
white_space::normal => CompressWhitespaceNewline,
white_space::pre => CompressNone,
@@ -179,9 +177,6 @@ impl TextRunScanner {
// First, transform/compress text of all the nodes.
let mut last_whitespace_in_clump = new_whitespace;
let transformed_strs: Vec<String> = Vec::from_fn(self.clump.length().to_uint(), |i| {
// TODO(#113): We should be passing the compression context between calls to
// `transform_text`, so that fragments starting and/or ending with whitespace can
// be compressed correctly with respect to the text run.
let idx = CharIndex(i as int) + self.clump.begin();
let in_fragment = match in_fragments[idx.to_uint()].specific {
UnscannedTextFragment(ref text_fragment_info) => &text_fragment_info.text,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.