Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix inline size bubbling with fixed width block. Improve intrinsic inline size calculation for text fragments. #3217
Conversation
…line size calculation for text fragments. These two fixes are related to the wikipedia metabug #2554. They don't make the wikipedia page look better (they cause a slight regression in the top caption table), but they are prerequisites for fixing some of the other layout issues that remain. Added reftests for each of the three cases I have come across that this patch solves.
hoppipolla-critic-bot
commented
Sep 5, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2508 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r+ |
jdm
added a commit
that referenced
this pull request
Sep 5, 2014
Fix inline size bubbling with fixed width block. Improve intrinsic inline size calculation for text fragments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedSep 5, 2014
These two fixes are related to the wikipedia metabug #2554.
They don't make the wikipedia page look better (they cause a slight regression in the top caption table), but they are prerequisites for fixing some of the other layout issues that remain.
Added reftests for each of the three cases I have come across that this patch solves.