Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to Rust 0.6. #322
Merged
Update to Rust 0.6. #322
+1,051
−1,138
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/servo-gfx/image/holder.rs in c850b59
Apr 4, 2013
|
Funky indentation for the body of this function. |
This comment has been minimized.
This comment has been minimized.
|
I think this might be a GitHub bug. It looks normal in the actual file. Can you double check the actual file on your side? |
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/servo-gfx/surface.rs in c850b59
Apr 4, 2013
|
Funky indentation for the body here. |
This comment has been minimized.
This comment has been minimized.
|
Ditto to this one. |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Apr 4, 2013
|
You used a tab instead of space. Fix both, please? |
|
I'm having a whirl at building it now to see if it resolves #321 |
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/servo/html/hubbub_html_parser.rs in c850b59
Apr 4, 2013
|
Please file a rust issue about how the is incorrectly reported as unused. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/servo/layout/box.rs in c850b59
Apr 4, 2013
|
FIXME here as well? |
This comment has been minimized.
This comment has been minimized.
|
Added. |
This comment has been minimized.
This comment has been minimized.
jdm
commented on c850b59
Apr 4, 2013
|
You really had fun with the borrow checker, didn't you? |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Apr 4, 2013
|
Also, please update the rust submodule to point to the revision you're using. |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Add a test for passing null to addEventListener and removeEventListener.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fix a couple of println -> debug macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedApr 4, 2013
No description provided.