Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement TreeWalker #3253
Merged
Implement TreeWalker #3253
Conversation
hoppipolla-critic-bot
commented
Sep 8, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2536 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Woo! This is an exciting PR! |
|
|
PASS expected FAIL -- |
|
You're correct that the test failures fall outside the purview of this PR. This is ready to merge after rebasing and squashing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ChrisParis commentedSep 8, 2014
Addresses #1234. This implementation allows NodeFilters to be provided as JavaScript objects, for the normal use case, but also as native Rust functions. This is so that TreeWalker can be used internally. This could be useful, for example, in implementing HTMLOptionElement.text, in which we have to skip script elements and children. You can see this worked out at ChrisParis@c1bb1e7.
I've submitted test cases to https://github.com/w3c/web-platform-tests. The tests in which the NodeFilter either isn't callable or throws an exception don't work. It looks like that has something to do with the automatically generated code.