Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement basic support for display: inline-block. #3286
Conversation
hoppipolla-critic-bot
commented
Sep 11, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2563 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@pcwalton - this is very much a prototype - would be good to know if I'm on the right track with how you were thinking of structuring it though. |
| @@ -838,6 +879,12 @@ impl<'a, 'b> PostorderNodeMutTraversal for FlowConstructor<'a, 'b> { | |||
| node.set_flow_construction_result(construction_result) | |||
| } | |||
|
|
|||
| // Inline items contribute inline fragment construction results. | |||
This comment has been minimized.
This comment has been minimized.
|
Looks straightforward. r=me with comment fixed. |
|
7772fd1
to
03f9306
|
cc #225 |
|
Rebased (again!) |
This still needs a lot of work, but it covers the basic cases and improves wikipedia while passing all existing tests. Tweak reftest to deal with linux/travis black background.
|
Travis seems to be acting funny so I'll merge this and take responsibility for backing out if it breaks stuff. |
Implement basic support for display: inline-block.
b64f27b
into
servo:master
glennw commentedSep 11, 2014
This still needs a lot of work, but it covers the basic
cases and improves wikipedia while passing all existing tests.