Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplayout: Don't crash on floated generated content. #3293
Merged
Conversation
hoppipolla-critic-bot
commented
Sep 11, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2567 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
One issue in Critic. |
|
This also needs a rebase, but has passed Travis. |
pcwalton
force-pushed the
pcwalton:floated-generated-content-crash
branch
from
31c92b9
to
dd542e3
|
re-r? @metajack |
pcwalton
force-pushed the
pcwalton:floated-generated-content-crash
branch
from
dd542e3
to
41ffec0
pcwalton
added a commit
that referenced
this pull request
Sep 12, 2014
layout: Don't crash on floated generated content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedSep 11, 2014
It doesn't construct the float correctly, but at least it doesn't crash
anymore.
Fixes Reddit.
Closes #3287.
r? @metajack