Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPropagate absolute descendants of inline block flows. Fixes #3326. #3331
Conversation
hoppipolla-critic-bot
commented
Sep 14, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2591 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Could you add a reftest for this? |
|
r=me once there is a reftest. |
|
Hmmm, I just tried to add one and it doesn't render correctly. But the PR above fixes the crash so I'll merge that and open an issue for absolutely positioned items inside an inline-block. |
glennw
added a commit
that referenced
this pull request
Sep 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedSep 14, 2014
No description provided.