Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all iframes attached to a document default to about:blank. #3347

Merged
merged 1 commit into from Sep 16, 2014

Conversation

@jdm
Copy link
Member

jdm commented Sep 15, 2014

This allows the CNN homepage to load successfully.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Sep 15, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2599

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member Author

jdm commented Sep 15, 2014

Fixes #3292.

metajack added a commit that referenced this pull request Sep 16, 2014
Make all iframes attached to a document default to about:blank.
@metajack metajack merged commit 8a02fe0 into servo:master Sep 16, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@jdm jdm deleted the jdm:blankiframe branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.