Implement HTMLOptionElement.text #3023

[jkim-julie]

Implement HTMLOptionElement.text

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/2606

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

[jdm]

I have left comments on Critic. When addressing them, please make additional commits instead of rewriting the one that has been reviewed. Thanks for the patch!

[aydinkim]

@jdm Hi! Retrying build with this commit on latest upstream(d7ffe7a), build is done successfully.
Could you r+ this again? I think that the thing had come from another reasons.

[jdm]

Yeah, we keep having a broken master; sorry about that. @jejuliekim can you please squash these commits together and push again?

[jkim-julie]

@aydinkim @jdm Thank you for your help. I am getting familiar with this process. I really appreciate that.

[jkim-julie]

I'll look into it, why it causes TC failed.

[jkim-julie]

@jdm ,
Because there are setting for TC skip at tests/wpt/metadata/html/semantics/forms/the-option-element,
it caused "Expected FAIL, got PASS" for option-text-backslash.html, option-text-recurse.html and element/option-text-spaces.html.
After remove that metadata, I got below.
20:59.43 TEST_START: Thread-TestrunnerManager-1 /html/semantics/forms/the-option-element/option-text-backslash.html
20:59.72 TEST_END: Thread-TestrunnerManager-1 Harness OK. Subtests passed 1/1. Unexpected 0
20:59.72 TEST_START: Thread-TestrunnerManager-1 /html/semantics/forms/the-option-element/option-text-recurse.html
20:59.85 TEST_END: Thread-TestrunnerManager-1 Harness OK. Subtests passed 9/9. Unexpected 0
20:59.85 TEST_START: Thread-TestrunnerManager-1 /html/semantics/forms/the-option-element/option-text-spaces.html

Do I need to upload new commit with removing skip-metadata for option-text here?
Or, create a new PR for handling removing it?
Let me know anything I have to.
Thanks a lot,

[jdm]

Please squash the commits together and push it in this PR.