Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded more complex profiling metadata. #3379
Conversation
hoppipolla-critic-bot
commented
Sep 16, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2614 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@pcwalton want to be my reviewer? :) |
|
Suggestion: Maybe abbreviate the names a little bit? Blink just uses "Style Recalc" and "Layout", which seem good to me. |
|
Also a suggestion: "Bucket size" has always been a confusing term. "Events" is probably a better name, since it represents the number of events that were recorded. |
|
Other than that, code looks good! |
Added more complex profiling metadata.
cgaebel commentedSep 16, 2014
This changes the profiling output from:
to:
This patch will not currently build without a checkout of
https://github.com/cgaebel/rust-url:cgaebel-servo-backportlisted as anoverride in your ~/.cargo/config.
This is blocked on servo/rust-url#29, however, is ready
for review now.