Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SpiderMonkey #3385

Closed
wants to merge 11 commits into from
Closed

Upgrade SpiderMonkey #3385

wants to merge 11 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Sep 17, 2014

@highfive
Copy link

highfive commented Sep 17, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Sep 17, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2616

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm force-pushed the jdm:smup3 branch from 578894d to 3456b2f Sep 19, 2014
@jdm
Copy link
Member Author

jdm commented Sep 23, 2014

For the benefit of reviewers:

  • Root<T> is Servo's Rooted<T>, and is structurally equivalent so it can be stored in SM's root stacks
  • Temporary<T> encapsulates identical behaviour to PersistentRooted<T> (which is duplicated in PersistentRootedObjectElement, structurally equivalent to PersistentRooted<JSObject*>)
  • JS<T> acts as Heap<T>
  • MutNullableJS<T> is a Heap<T> that implements write barriers

Also take a look at servo/rust-mozjs#106, which does some lower-level integration with SpiderMonkey.

@jdm jdm force-pushed the jdm:smup3 branch from 3456b2f to b6fd3bd Sep 30, 2014
@jdm jdm closed this Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.