Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes #3353: rust snapshot downloads to home directory #3388
Conversation
hoppipolla-critic-bot
commented
Sep 17, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2618 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Sep 17, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon. |
|
Could we have a Also, this will break Travis doc uploading, either have Travis use the local variants of the commands as proposed above, or teach it about the new location of Rust docs. Travis scripts are in |
|
If you include the rust-snapshot-hash in the directory name under ~/.servo you can make this work even in the multiple clones using different Rusts case. I think that is better than the |
|
Could the |
|
@SimonSapin That seems like an edge case. Can you explain the motivation? |
|
Which method is more preferable in the case of working on Rust upgrades? @metajack How would multiple snapshot-hashes work? Like a |
|
Like ~/.servo/rust-ab847ea75e -----Original Message----- Which method is more preferable in the case of working on Rust upgrades? @metajack How would multiple snapshot-hashes work? Like a ~/.servo//rust? |
|
How do the old unused versions get purged? Wont the snapshots start adding up? |
|
Purge manually or with another mach command :) |
acmiyaguchi
force-pushed the
acmiyaguchi:share_directory
branch
from
c71f476
to
c9084fc
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
That way, whenever rust-snapshot-hash changes, mach will look for the Rust snapshot in a different directory and re-boostrap as needed. However, older rust version will be left behind never cleaned up. This is good for git-bisect, but not for disk space: the current snapshot is 618 MB. In the future, we may want `mach clean` or some other comment to remove unused Rust snapshots. CC #3388
|
I rebased this patch onto master, and pushed the rebased version to #3902. Thanks! |
This is @acmiyaguchi's already-reviewed patch from #3388, rebased and squashed onto servo master. Fixes #3353.
This is @acmiyaguchi's already-reviewed patch from #3388, rebased and squashed onto servo master. Fixes #3353.
This is @acmiyaguchi's already-reviewed patch from #3388, rebased and squashed onto servo master. Fixes #3353.
This is @acmiyaguchi's already-reviewed patch from #3388, rebased and squashed onto servo master. Fixes #3353.
acmiyaguchi commentedSep 17, 2014
Moves the default rust snapshot and cargo directories to ~/.servo to build across multiple clones of the repository.