Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix img with display: block. Fixes text/image overflow on wikipedia. #3419
Conversation
hoppipolla-critic-bot
commented
Sep 19, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2636 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r+, nice improvement! |
|
Rebased - will merge when green. |
glennw
added a commit
that referenced
this pull request
Sep 19, 2014
Fix img with display: block. Fixes text/image overflow on wikipedia.
| @@ -1646,8 +1646,12 @@ impl Flow for BlockFlow { | |||
|
|
|||
| fn assign_block_size<'a>(&mut self, ctx: &'a LayoutContext<'a>) { | |||
| if self.is_replaced_content() { | |||
| let _scope = layout_debug_scope!("assign_replaced_block_size_if_necessary {:s}", | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedSep 19, 2014
Ref: #2554