Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace Namespace with Atom #3512
Closed
Conversation
hoppipolla-critic-bot
commented
Sep 28, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2718 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Sep 28, 2014
|
|
|
I'll open a new PR with the type wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kmcallister commentedSep 28, 2014
See discussion on kmcallister/html5ever#26.
This is part of the html5ever integration, but I'd like to get it in now to avoid excessive rebasing.