Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass a viewport to the rendering code #3525
Merged
+49
−43
Conversation
Part of servo/rust-layers#114
hoppipolla-critic-bot
commented
Sep 29, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2728 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
zwarich
commented on 5f0d2ae
Sep 29, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from zwarich |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/viewport = 5f0d2ae into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 01b4100 |
bors-servo
pushed a commit
that referenced
this pull request
Sep 29, 2014
Updates to the latest rust-layers and rust-geom to pick up servo/rust-layers#114. r? @zwarich
bors-servo
merged commit 5f0d2ae
into
servo:master
1 check passed
1 check passed
default
all tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedSep 29, 2014
Updates to the latest rust-layers and rust-geom to pick up
servo/rust-layers#114. r? @zwarich