Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade SpiderMonkey #3527
Closed
Upgrade SpiderMonkey #3527
+1,890
−904
Conversation
highfive
commented
Sep 30, 2014
|
|
hoppipolla-critic-bot
commented
Sep 30, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2730 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2014
… methods and dictionary members.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedSep 30, 2014
Requires servo/mozjs#18 and servo/rust-mozjs#106.
For the benefit of reviewers:
Root<T>is Servo'sRooted<T>, and is structurally equivalent so it can be stored in SM's root stacksTemporary<T>encapsulates identical behaviour toPersistentRooted<T>(which is duplicated inPersistentRootedObjectElement, structurally equivalent toPersistentRooted<JSObject*>)JS<T>acts asHeap<T>MutNullableJS<T>is aHeap<T>that implements write barriersAlso take a look at servo/rust-mozjs#106, which does some lower-level integration with SpiderMonkey.