Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not assume python is an interpreter for Python 2 #353
Conversation
|
An updated pull request from #338. |
|
The minimum version of python required for the bindings code generator is 2.7, so let's not check for older versions than that. |
On some distributions and configurations, the python command might refer to python3 instead of python2, breaking the build. Fix this by using the first of python2, python2.7, or python.
|
@jdm: Removed check for python2.{6,5}. |
|
This GitHub interface is a bit confusing :(. |
jdm
added a commit
that referenced
this pull request
Apr 8, 2013
Do not assume python is an interpreter for Python 2
|
Thanks! |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Fix query string bug that invalidates test
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add Api to access glyph dimensions With this, standalone applications will be able to handle glyph spacing and/or positioning. Currently the workaround would be setting up a font renderer by yourself, but this would involve use of plattform dependent libraries and introduce overhead, since the texture cache already knows about the glyph dimensions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/353) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ereski commentedApr 8, 2013
On some distributions and configurations, the python command might refer to
python3 instead of python2, breaking the build. Fix this by using the first of
python2, python2.7, or python.