servoshell: Port Authentication dialog code to use egui instead of tinyfiledialogs#35507
Conversation
| if self.inner_mut().focused_webview_id.is_none() { | ||
| self.inner_mut().focused_webview_id = Some(webview.id()); | ||
| } |
There was a problem hiding this comment.
I looked into this a bit and I think it will be hard to fix this issue before we do more changes in the compositor (having a compositor per WebView and setting up the association synchronously when creating WebViews). In the meantime maybe we can look into just setting focused_webview_id as the first WebView we create when creating AppState.
There was a problem hiding this comment.
I've slightly modified this workaround to be a bit less invasive.
There was a problem hiding this comment.
I just pushed this dialog with corrections without the changes you have done, is that alright?
i added the patch @mukilan gave to fix the background mouse interactions and also the Escape and Enter keyboard interactions.
bbb4251 to
284a7ed
Compare
Head branch was pushed to by a user without write access
284a7ed to
cd118f1
Compare
|
@chickenleaf I had pushed my changes to your branch and it seems that your latest push has overriden them and also added a new commit fixing the mouse interaction issue. I think we should go ahead and stick with 284a7ed for this change and then do the mouse interaction fixes in a new PR. I will repush to this branch and then at that point you just need to open a new PR with your changes. |
cd118f1 to
284a7ed
Compare
|
Okay. I have pushed the changes again. Nothing more is needed in this PR from you @chickenleaf. Thanks! |
| let authentication_dialog = Dialog::new_authentication_dialog(authentication_request); | ||
| self.add_dialog(webview, authentication_dialog); |
There was a problem hiding this comment.
We need to make sure that when in headless mode we do not create the dialog. I'll make this change.
There was a problem hiding this comment.
The reason here is that if we are in headless mode, the dialog will be added to the list of dialogs, but never resolved, since there is no UI for the user to resolve it. This headless mode is used for WPT test which is why landing this hit test failures.
…yfiledialogs Signed-off-by: L Ashwin B <lashwinib@gmail.com>
284a7ed to
d884688
Compare
tinyfiledialogstoegui./mach build -ddoes not report any errors./mach test-tidydoes not report any errors