Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DOM Range setStart/setEnd() #3559

Closed
wants to merge 17 commits into from
Closed

Implement DOM Range setStart/setEnd() #3559

wants to merge 17 commits into from

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Oct 2, 2014

Relate: #1236

This is the first step to support Range.
@tetsuharuohzeki
Add the defenition of InvalidNodeTypeError.
c85211e
@tetsuharuohzeki
Implement some Range attributes.
5413f6f 
  * Range.startContainer
  * Range.startOffset
  * Range.endContainer
  * Range.endOffset
  * Range.collapsed
@tetsuharuohzeki
Add NodeHelpers.length().
72239e1
@tetsuharuohzeki
Add NodeHelpers.get_tree_root().
4afd9a1
@tetsuharuohzeki
Add NodeHelpers::inclusive_ancestors().
b06925a
@tetsuharuohzeki
Implement Range.setStart(), Range.setEnd().
95d7920
@tetsuharuohzeki
Implement Range.setStartBefore(), Range.setStartAfter(), Range.setEnd…
8cd0312 
…Before(), and Range.setEndAfter().
@tetsuharuohzeki
Add the test for Range's initial state.
a9ef249
@tetsuharuohzeki
Simplify the check whether Range and the given node share the root.
eb2abe8
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 2, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2750

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@tetsuharuohzeki
fixup! Implement Range.setStart(), Range.setEnd().
5105050
@tetsuharuohzeki
fixup! Implement Range.setStart(), Range.setEnd().
7bde5d9
@tetsuharuohzeki
fixup! Add NodeHelpers::inclusive_ancestors().
52f25e3
@tetsuharuohzeki
fixup! Add NodeHelpers::inclusive_ancestors().
6dcce74
@tetsuharuohzeki
fixup! Add NodeHelpers.length().
76cf6a4
@tetsuharuohzeki
Make Range's fields MutNullableJS<T>.
9162b56
@tetsuharuohzeki
fixup! Make Range's fields MutNullableJS<T>.
b16bf0b
@tetsuharuohzeki
fixup! Implement Range.setStart(), Range.setEnd().
4f844c8
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Oct 16, 2014

At this moment, this implementation don't care when the tree is changed. I need to work it.
@jdm
Copy link
Member

jdm commented Mar 31, 2015

We can reopen this if necessary, but it doesn't appear to be going anywhere :)
@jdm jdm closed this Mar 31, 2015
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:range branch Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-code-changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@tetsuharuohzeki @hoppipolla-critic-bot @jdm
You can’t perform that action at this time.