Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android build config to mach/servobuild #3568

Merged
merged 1 commit into from Oct 3, 2014

Conversation

Projects
None yet
4 participants
@mbrubeck
Copy link
Contributor

commented Oct 3, 2014

This allows setting Android toolchain paths in .servobuild, and also adds a --android option that sets the correct default target and causes mach build to also build the APK.

@hoppipolla-critic-bot

This comment has been minimized.

Copy link

commented Oct 3, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2762

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack

This comment has been minimized.

Copy link

commented on b736256 Oct 3, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented on b736256 Oct 3, 2014

saw approval from metajack
at mbrubeck@b736256

This comment has been minimized.

Copy link
Contributor

replied Oct 3, 2014

merging mbrubeck/servo/mach-android = b736256 into auto

This comment has been minimized.

Copy link
Contributor

replied Oct 3, 2014

mbrubeck/servo/mach-android = b736256 merged ok, testing candidate = bf7beb4

This comment has been minimized.

Copy link
Contributor

replied Oct 3, 2014

This comment has been minimized.

Copy link
Contributor

replied Oct 3, 2014

fast-forwarding master to auto = bf7beb4

bors-servo pushed a commit that referenced this pull request Oct 3, 2014

bors-servo
auto merge of #3568 : mbrubeck/servo/mach-android, r=metajack
This allows setting Android toolchain paths in `.servobuild`, and also adds a `--android` option that sets the correct default target and causes `mach build` to also build the APK.

@bors-servo bors-servo closed this Oct 3, 2014

@bors-servo bors-servo merged commit b736256 into servo:master Oct 3, 2014

1 check passed

default all tests passed

@mbrubeck mbrubeck deleted the mbrubeck:mach-android branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.