Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove trailing whitespace #3592
Conversation
hoppipolla-critic-bot
commented
Oct 6, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2782 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
Oct 6, 2014
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging zwarich/servo/trailing-whitespace = fb810c0 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Manishearth |
This comment has been minimized.
This comment has been minimized.
|
merging zwarich/servo/trailing-whitespace = fb810c0 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = ae946a9 |
fb810c0
into
servo:master
|
Do we want to remove all trailing white spaces? If so I will remove them as I spot them during other code modifications. |
|
Sure, though |
zwarich commentedOct 6, 2014
The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.