Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace #3592

Merged
merged 1 commit into from Oct 7, 2014
Merged

Remove trailing whitespace #3592

merged 1 commit into from Oct 7, 2014

Conversation

@zwarich
Copy link

zwarich commented Oct 6, 2014

The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.

Cameron Zwarich
The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 6, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2782

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Oct 6, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on fb810c0 Oct 6, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 6, 2014

merging zwarich/servo/trailing-whitespace = fb810c0 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 6, 2014

zwarich/servo/trailing-whitespace = fb810c0 merged ok, testing candidate = 3dacbfa

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 6, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 7, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 7, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 7, 2014

merging zwarich/servo/trailing-whitespace = fb810c0 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 7, 2014

zwarich/servo/trailing-whitespace = fb810c0 merged ok, testing candidate = ae946a9

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 7, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 7, 2014

fast-forwarding master to auto = ae946a9

bors-servo pushed a commit that referenced this pull request Oct 6, 2014
The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.
bors-servo pushed a commit that referenced this pull request Oct 7, 2014
The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.
bors-servo pushed a commit that referenced this pull request Oct 7, 2014
The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.
bors-servo pushed a commit that referenced this pull request Oct 7, 2014
The Mach test runner doesn't actually make these failures yet, which is
tracked by #3482.
@bors-servo bors-servo closed this Oct 7, 2014
@bors-servo bors-servo merged commit fb810c0 into servo:master Oct 7, 2014
1 check passed
1 check passed
default all tests passed
@gilles-leblanc
Copy link
Contributor

gilles-leblanc commented Oct 7, 2014

Do we want to remove all trailing white spaces? If so I will remove them as I spot them during other code modifications.

@Manishearth
Copy link
Member

Manishearth commented Oct 7, 2014

Sure, though mach test-tidy should catch most of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.