Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force a reflow after adding a stylesheet #3633

Closed
wants to merge 1 commit into from
Closed

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 10, 2014

This fixes a race (exposed in some reftests by #3563) where the document's
first paint happens before the stylesheet is added, and it never updates
after the stylesheet loads.

r? @jdm

This fixes a race (exposed in some reftests by #3563) where the document's
first paint happens before the stylesheet is added, and it never updates
after the stylesheet loads.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 10, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2828

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm

This comment has been minimized.

Copy link
Collaborator

jdm commented on 5011fd3 Oct 10, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 5011fd3 Oct 10, 2014

saw approval from jdm
at mbrubeck@5011fd3

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 10, 2014

merging mbrubeck/servo/relayout = 5011fd3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 10, 2014

mbrubeck/servo/relayout = 5011fd3 merged ok, testing candidate = 9024eef

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 10, 2014

bors-servo pushed a commit that referenced this pull request Oct 10, 2014
This fixes a race (exposed in some reftests by #3563) where the document's
first paint happens before the stylesheet is added, and it never updates
after the stylesheet loads.

r? @jdm
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Oct 10, 2014

The test that failed on Linux was the exact one this was intended to fix. So I guess it doesn't have the desired effect. :/ Closing for now, and we should probably disable the test until it can be fixed for real.

@mbrubeck mbrubeck closed this Oct 10, 2014
@mbrubeck mbrubeck deleted the mbrubeck:relayout branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.