Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upForce a reflow after adding a stylesheet #3633
Conversation
hoppipolla-critic-bot
commented
Oct 10, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2828 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/relayout = 5011fd3 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
|
The test that failed on Linux was the exact one this was intended to fix. So I guess it doesn't have the desired effect. :/ Closing for now, and we should probably disable the test until it can be fixed for real. |
mbrubeck commentedOct 10, 2014
This fixes a race (exposed in some reftests by #3563) where the document's
first paint happens before the stylesheet is added, and it never updates
after the stylesheet loads.
r? @jdm