Implement extremely basic form submission #3642

Manishearth · 2014-10-10T21:44:43Z

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in.

What works:

<input> elements except for type=file
GET/POST methods
URLencoded enctypes (default)
Submission via <form>.submit() only

Stuff that needs to be done for most simple real-world cases to work:

Working text input
Click handlers for <submit>
Possibly <textarea> support
Support for the other two enctypes (#3649)

Todo:

Correctly implement planned navigation using TrustedFormAddress (#3648)
Correctly implement form owners. Requires html5ever and some discussion of the spec.
<input type=file> support
Image submit support
Browsing contexts/targets
Support for non-<input> controls
Validation (?)
Dirname (?)

hoppipolla-critic-bot · 2014-10-10T21:44:47Z

Critic review: https://critic.hoppipolla.co.uk/r/2840

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Manishearth · 2014-10-10T21:51:44Z

I haven't yet updated the wpt expectations since wpt is acting a bit wonky -- I'll do it in a while.


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        Add type IDL attr for submittable elements


        Fix <input>.checked


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)

jdm · 2014-10-11T05:27:56Z

Ugh, one layout race and one mysterious timeout.


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)

Manishearth · 2014-10-11T05:35:52Z

(Couldn't repro the timeout locally)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        Implement extremely basic form submission (fixes #3554)


        Correct <input>.value


        Address review comments


        Update wpt expectations

Manishearth · 2014-10-11T10:40:28Z

r=jdm

Manishearth · 2014-10-11T11:43:50Z

@bors: retry

Manishearth · 2014-10-11T12:26:26Z

@bors: retry

Manishearth · 2014-10-11T13:42:08Z

@bors: retry

bors-servo · 2014-10-11T10:42:37Z

saw approval from jdm
at Manishearth@ca2d5d3

bors-servo · 2014-10-11T10:42:38Z

merging Manishearth/servo/form-submit = ca2d5d3 into auto

bors-servo · 2014-10-11T10:42:38Z

Manishearth/servo/form-submit = ca2d5d3 merged ok, testing candidate = 3f6a9b9

bors-servo · 2014-10-11T11:09:38Z

some tests failed:
failure: http://build.servo.org/builders/mac/builds/217

bors-servo · 2014-10-11T11:45:37Z

saw approval from jdm
at Manishearth@ca2d5d3

bors-servo · 2014-10-11T13:45:38Z

saw approval from jdm
at Manishearth@ca2d5d3

bors-servo · 2014-10-11T13:45:39Z

merging Manishearth/servo/form-submit = ca2d5d3 into auto

bors-servo · 2014-10-11T13:45:39Z

Manishearth/servo/form-submit = ca2d5d3 merged ok, testing candidate = 9dfd5e7

bors-servo · 2014-10-11T14:12:39Z

all tests pass:
success: http://build.servo.org/builders/linux/builds/215
success: http://build.servo.org/builders/mac/builds/220

bors-servo · 2014-10-11T14:15:39Z

fast-forwarding master to auto = 9dfd5e7


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)

Manishearth · 2014-10-11T12:56:03Z

I'm getting intermittent timeouts on /html/semantics/forms/the-input-element/type-change-state.html and a lot of random intermittent failures (keep changing every time)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)

Manishearth force-pushed the Manishearth:form-submit branch 2 times, most recently from 08098f4 to aea5666 Oct 11, 2014

Manishearth added 2 commits Oct 10, 2014

Add type IDL attr for submittable elements

8a2c746

Fix <input>.checked

cc6e811

Manishearth force-pushed the Manishearth:form-submit branch from aea5666 to 850572f Oct 11, 2014

This was referenced Oct 11, 2014

Implement form submission for <button> and <input type=submit> #3647

Closed

Correctly implement planned navigation #3648

Closed

Support application/form-data and text/plain #3649

Closed

Manishearth added 4 commits Oct 10, 2014

Implement extremely basic form submission (fixes #3554)

b28a4c8

Correct <input>.value

10d9a66

Address review comments

76219df

Update wpt expectations

Loading status checks…

ca2d5d3

Manishearth force-pushed the Manishearth:form-submit branch from 850572f to ca2d5d3 Oct 11, 2014

bors-servo closed this Oct 11, 2014

bors-servo merged commit ca2d5d3 into servo:master Oct 11, 2014
1 check passed

1 check passed

default all tests passed

servo / servo

Implement extremely basic form submission #3642

Implement extremely basic form submission #3642

Manishearth commented Oct 10, 2014

hoppipolla-critic-bot commented Oct 10, 2014

Manishearth commented Oct 10, 2014

jdm commented Oct 11, 2014

Manishearth commented Oct 11, 2014

This comment has been minimized.

Manishearth commented on `ca2d5d3` Oct 11, 2014

This comment has been minimized.

Manishearth replied Oct 11, 2014

This comment has been minimized.

Manishearth replied Oct 11, 2014

This comment has been minimized.

Manishearth replied Oct 11, 2014

This comment has been minimized.

bors-servo commented on `ca2d5d3` Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

Manishearth commented Oct 11, 2014

servo / servo

Join GitHub today

Implement extremely basic form submission #3642

Implement extremely basic form submission #3642

Conversation

Manishearth commented Oct 10, 2014

hoppipolla-critic-bot commented Oct 10, 2014

Manishearth commented Oct 10, 2014

jdm commented Oct 11, 2014

Manishearth commented Oct 11, 2014

This comment has been minimized.

Manishearth commented on ca2d5d3 Oct 11, 2014

This comment has been minimized.

Manishearth replied Oct 11, 2014

This comment has been minimized.

Manishearth replied Oct 11, 2014

This comment has been minimized.

Manishearth replied Oct 11, 2014

This comment has been minimized.

bors-servo commented on ca2d5d3 Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

This comment has been minimized.

bors-servo replied Oct 11, 2014

Manishearth commented Oct 11, 2014

Manishearth commented on `ca2d5d3` Oct 11, 2014

bors-servo commented on `ca2d5d3` Oct 11, 2014