Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image element to work #369

Merged
merged 1 commit into from Apr 16, 2013
Merged

fix image element to work #369

merged 1 commit into from Apr 16, 2013

Conversation

@aydinkim
Copy link

aydinkim commented Apr 16, 2013

Fix #301

@metajack
Copy link
Contributor

metajack commented Apr 16, 2013

This is great! I think we can remove the two extra macros by adding a field list to the html_element! macro. Here's what I came up with: https://gist.github.com/metajack/5393614

I can't seem to get the syntax nicer than that since removing the parens seems to make it an ambiguous parse (which I think is a Rust parser bug). Can you apply that and update the PR?

@aydinkim
Copy link
Author

aydinkim commented Apr 16, 2013

That's very nice idea!
I tried to find out the way to make integrated macro like your code, but failed.
I have modified the commit codes as you suggested, and applied.
Thank you :)

metajack added a commit that referenced this pull request Apr 16, 2013
fix image element to work
@metajack metajack merged commit 62e5b9c into servo:master Apr 16, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
Delete tests looking for the audio attribute in <video> since it doesn't exist
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Add profile counter support for frame construction.

Initially, this reports the total / visible primitives for this frame.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/369)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.