Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIgnore the HTML parser's borrow flag in GC tracing #3716
Conversation
hoppipolla-critic-bot
commented
Oct 17, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2900 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
|
r=mbrubeck |
This comment has been minimized.
This comment has been minimized.
mbrubeck
replied
Oct 21, 2014
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
pcwalton
replied
Oct 21, 2014
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from mbrubeck |
This comment has been minimized.
This comment has been minimized.
|
merging kmcallister/servo/tokenizercell = 0debc87 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from mbrubeck |
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from mbrubeck |
This comment has been minimized.
This comment has been minimized.
|
merging kmcallister/servo/tokenizercell = 0debc87 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This looks like a genuine fix caused by this patch. You'll need to |
|
It involves iframes, which makes me suspect an intermittent pass. Hopefully that will be corrected by #3759. |
|
Hm, maybe I should just add the ability to break the rules to |
kmcallister commentedOct 17, 2014
r? @mbrubeck (who hit the bug), @pcwalton (who advised me on the safety of possible solutions)