Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Opera's script scheduling tests. #3754

Closed
wants to merge 1 commit into from
Closed

Enable Opera's script scheduling tests. #3754

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 21, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 21, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2931

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Manishearth
Copy link
Member

Manishearth commented Oct 21, 2014

Shouldn't we wait for #3721 to land?
bors-servo pushed a commit that referenced this pull request Oct 21, 2014
bors-servo
auto merge of #3754 : Ms2ger/servo/enable-script-tests, r=Manishearth
Loading status checks…
1db7548
@Ms2ger
Enable Opera's script scheduling tests.
Loading status checks…
7cc8ff9
@Ms2ger Ms2ger force-pushed the Ms2ger:enable-script-tests branch from 830e735 to 7cc8ff9 Oct 21, 2014
@Manishearth

This comment has been minimized.

Sign in to view
Copy link

Manishearth commented on 7cc8ff9 Oct 21, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 7cc8ff9 Oct 21, 2014

saw approval from Manishearth
at Ms2ger@7cc8ff9

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 21, 2014

merging Ms2ger/servo/enable-script-tests = 7cc8ff9 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 21, 2014

Ms2ger/servo/enable-script-tests = 7cc8ff9 merged ok, testing candidate = 983d180

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 21, 2014

all tests pass:
success: http://build.servo.org/builders/linux/builds/377
success: http://build.servo.org/builders/mac/builds/384

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 21, 2014

fast-forwarding master to auto = 983d180
bors-servo pushed a commit that referenced this pull request Oct 21, 2014
bors-servo
auto merge of #3754 : Ms2ger/servo/enable-script-tests, r=Manishearth
Loading status checks…
983d180
@bors-servo bors-servo closed this Oct 21, 2014
@Ms2ger Ms2ger deleted the Ms2ger:enable-script-tests branch Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @hoppipolla-critic-bot @Manishearth @bors-servo
You can’t perform that action at this time.