Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Document.readyState. Prevent iframes from notifying the compos... #3759
Conversation
hoppipolla-critic-bot
commented
Oct 21, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/2938 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Can either @Ms2ger or @Manishearth please take a look at this? I believe it's blocking a PR from @kmcallister which is in turn blocking a PR from @mbrubeck :-) |
|
In a way #3776 blocks this one, lengthening the chain ;P |
|
@mbrubeck You probably know this, but be a bit careful about the |
This comment has been minimized.
This comment has been minimized.
|
r=Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
saw approval from Ms2ger |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/readystate = 539c21f into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 2df2363 |
...itor after the initial parse. Fixes #1720. Fixes #3738. r? @Ms2ger or @Manishearth
|
As noted in another PR, in the case of Gecko, I found that it would be beneficial to have state tracking across the navigation. If such a state tracking object existed, it would be logical for the true |
jdm commentedOct 21, 2014
...itor after the initial parse. Fixes #1720. Fixes #3738.
r? @Ms2ger or @Manishearth