Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document.readyState. Prevent iframes from notifying the compos... #3759

Closed
wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Oct 21, 2014

...itor after the initial parse. Fixes #1720. Fixes #3738.

r? @Ms2ger or @Manishearth

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 21, 2014

Critic review: https://critic.hoppipolla.co.uk/r/2938

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 22, 2014

Can either @Ms2ger or @Manishearth please take a look at this? I believe it's blocking a PR from @kmcallister which is in turn blocking a PR from @mbrubeck :-)

@Manishearth
Copy link
Member

Manishearth commented Oct 22, 2014

In a way #3776 blocks this one, lengthening the chain ;P

@Manishearth
Copy link
Member

Manishearth commented Oct 22, 2014

@mbrubeck You probably know this, but be a bit careful about the interactive ready state (scroll up) for #3721 once this merges.

@jdm jdm force-pushed the jdm:readystate branch from d1aa7da to acf892d Oct 23, 2014
…positor after the initial parse. Fixes #1720. Fixes #3738.
@jdm jdm force-pushed the jdm:readystate branch from dbfa142 to 539c21f Oct 23, 2014
@jdm

This comment has been minimized.

Copy link
Owner Author

jdm commented on 539c21f Oct 23, 2014

r=Ms2ger

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 539c21f Oct 23, 2014

saw approval from Ms2ger
at jdm@539c21f

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 23, 2014

merging jdm/servo/readystate = 539c21f into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 23, 2014

jdm/servo/readystate = 539c21f merged ok, testing candidate = 2df2363

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 23, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 23, 2014

fast-forwarding master to auto = 2df2363

bors-servo pushed a commit that referenced this pull request Oct 23, 2014
...itor after the initial parse. Fixes #1720. Fixes #3738.

r? @Ms2ger or @Manishearth
@bors-servo bors-servo closed this Oct 23, 2014
@hsivonen
Copy link
Contributor

hsivonen commented Nov 24, 2014

As noted in another PR, in the case of Gecko, I found that it would be beneficial to have state tracking across the navigation. If such a state tracking object existed, it would be logical for the true readyState to be kept on that object such that once Document is created, it would get a reference to the associated navigation tracking object and the Document's readyState could then call through to that object to ask for the state.

@jdm jdm deleted the jdm:readystate branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.