Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layers, opengles to use the new glx bindings. #3845

Closed
wants to merge 1 commit into from
Closed

Update layers, opengles to use the new glx bindings. #3845

wants to merge 1 commit into from

Conversation

@glennw
Copy link
Member

glennw commented Oct 29, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 29, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3017

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@glennw
Copy link
Member Author

glennw commented Oct 29, 2014

r? @metajack or @mbrubeck
@gw3583
Update layers, opengles to use the new glx bindings.
Loading status checks…
450b3a9
@glennw glennw force-pushed the glennw:update-layers-opengles branch from b0a7ca6 to 450b3a9 Oct 29, 2014
@glennw
Copy link
Member Author

glennw commented Oct 29, 2014

Rebased and built on linux, android, cef.
@metajack
Copy link
Contributor

metajack commented Oct 29, 2014

Ack, you broke Critic.
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on 450b3a9 Oct 29, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 450b3a9 Oct 29, 2014

saw approval from metajack
at glennw@450b3a9

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 29, 2014

merging glennw/servo/update-layers-opengles = 450b3a9 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 29, 2014

glennw/servo/update-layers-opengles = 450b3a9 merged ok, testing candidate = f632f64

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 29, 2014

all tests pass:
success: http://build.servo.org/builders/linux/builds/481
success: http://build.servo.org/builders/mac1/builds/26
success: http://build.servo.org/builders/mac2/builds/25

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Oct 29, 2014

fast-forwarding master to auto = f632f64
bors-servo pushed a commit that referenced this pull request Oct 29, 2014
bors-servo
auto merge of #3845 : glennw/servo/update-layers-opengles, r=metajack
Loading status checks…
f632f64
@bors-servo bors-servo closed this Oct 29, 2014
@glennw glennw deleted the glennw:update-layers-opengles branch Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@glennw @hoppipolla-critic-bot @metajack @bors-servo @gw3583
You can’t perform that action at this time.