Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to use CGL crate for mac. #3846
Conversation
hoppipolla-critic-bot
commented
Oct 29, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3018 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @metajack (relies on submodules being merged first) |
|
This needs a rebase. |
|
Yep - I will wait until the linux/glx one merges first though, because it will need another rebase after that. |
2efcbd8
to
d5f365a
|
Rebased - this diff is much simpler now - tested that it builds on linux, mac, cef, android. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 5e5f761
Oct 29, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/cgl = 5e5f761 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b8de54b |
glennw commentedOct 29, 2014
No description provided.