Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use CGL crate for mac. #3846

Closed
wants to merge 1 commit into from
Closed

Update to use CGL crate for mac. #3846

wants to merge 1 commit into from

Conversation

@glennw
Copy link
Member

glennw commented Oct 29, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Oct 29, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3018

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Oct 29, 2014

r? @metajack (relies on submodules being merged first)

@metajack
Copy link
Contributor

metajack commented Oct 29, 2014

This needs a rebase.

@glennw
Copy link
Member Author

glennw commented Oct 29, 2014

Yep - I will wait until the linux/glx one merges first though, because it will need another rebase after that.

@glennw glennw force-pushed the glennw:cgl branch 2 times, most recently from 2efcbd8 to d5f365a Oct 29, 2014
@glennw glennw force-pushed the glennw:cgl branch from d5f365a to 5e5f761 Oct 29, 2014
@glennw
Copy link
Member Author

glennw commented Oct 29, 2014

Rebased - this diff is much simpler now - tested that it builds on linux, mac, cef, android.

@metajack

This comment has been minimized.

Copy link

metajack commented on 5e5f761 Oct 29, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 5e5f761 Oct 29, 2014

saw approval from metajack
at glennw@5e5f761

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 29, 2014

merging glennw/servo/cgl = 5e5f761 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 29, 2014

glennw/servo/cgl = 5e5f761 merged ok, testing candidate = b8de54b

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 29, 2014

fast-forwarding master to auto = b8de54b

bors-servo pushed a commit that referenced this pull request Oct 29, 2014
@bors-servo bors-servo closed this Oct 29, 2014
@glennw glennw deleted the glennw:cgl branch Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.