Make PropertyDeclarationBlock store a single vector of declarations

[gilles-leblanc]

Changes PropertyDeclarationBlock to store a single vector instead of the
current two vectors; normal, important.

Fixes #3426

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/3055

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[cgaebel]

I think this struct is useless now.

[gilles-leblanc]

Yeah makes sense. It should probably be deleted.

I'll add it to the list of things to modify on this pull request.

[SimonSapin]

@cgaebel, please use Critic :)

[SimonSapin]

Reviewed on Critic. Please see https://critic.hoppipolla.co.uk/showcomment?chain=8473 in particular.

[gilles-leblanc]

@SimonSapin I've made another commit which corrects the The listandseenvariables are not needed anymore. Please remove them and use&mut foo inline. problem and also @cgaebel suggestion to remove PerOriginSelectorMap.

I haven't found what to do for This is incorrect, we need to preserve the order of (origin, importance).

Since the applicable_declarations are VecLike<DeclarationBlock> all I can see is implementing some form of iterator on VecLike.

If you can think of something I could implement I will wait your suggestion, if you would rather take it from now (as suggested in OperaCritic) that might also be a good idea since my time is severely limited for the next week and won't be able to put much time on this until next week.

Implementing an iterator has got me thinking will iterating and filtering the fields incur a (even if small) performance cost? I remember reading that the selector_matching was somewhere performance needed to be good.

[jdm]

@SimonSapin Is this something you're working on? Is it worth leaving this pull request open?

[SimonSapin]

It is in my queue but not at the top and I haven’t started yet. I don’t mind closing the PR (I just copied the branch) but is there a downside with leaving it open?

[metajack]

I'm closing this as it is breaking bors. Apparently the original repo no longer exists.