Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize 'cancelable' to false in Event::new_inherited. #3870

Merged
merged 2 commits into from Nov 2, 2014

Conversation

@mitchelljustin
Copy link
Contributor

mitchelljustin commented Nov 2, 2014

Fixes #3855.

I'm not sure if this is the right place to set cancelable. If changing the default value in Event::new_inherited is not satisfactory, it will be possible to set the Cell's value to false in Event::new itself.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 2, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3060

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 2, 2014

Replied on critic; please do make sure not to force-push as mentioned by @hoppipolla-critic-bot. Thanks!

…a because we expect all tests to pass now. Fixes #3855
@mitchelljustin
Copy link
Contributor Author

mitchelljustin commented Nov 2, 2014

@Ms2ger Alright, I've removed the .ini for Document-createEvent test since all tests pass now.
document-createevent

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 2, 2014

Looking good!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 128f162 Nov 2, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 2, 2014

merging mvanderh/servo/master = 128f162 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 2, 2014

mvanderh/servo/master = 128f162 merged ok, testing candidate = 9b2dae5

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 2, 2014

fast-forwarding master to auto = 9b2dae5

bors-servo pushed a commit that referenced this pull request Nov 2, 2014
Fixes #3855.

I'm not sure if this is the right place to set `cancelable`. If changing the default value in `Event::new_inherited` is not satisfactory, it will be possible to set the `Cell`'s value to `false` in `Event::new` itself.
@bors-servo bors-servo closed this Nov 2, 2014
@bors-servo bors-servo merged commit 128f162 into servo:master Nov 2, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.