Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DOMStringMap #3884

Merged
merged 3 commits into from Nov 6, 2014
Merged

Implement DOMStringMap #3884

merged 3 commits into from Nov 6, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Nov 4, 2014

This is a sub-task for #2974.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 4, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3075

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

bors-servo pushed a commit that referenced this pull request Nov 5, 2014
This is a sub-task for #2974.
@jdm
Copy link
Member

jdm commented Nov 6, 2014

This needs to update the content test test_interfaces.html as well.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on a9d6847 Nov 6, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 6, 2014

merging brunoabinader/servo/dataset = a9d6847 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 6, 2014

brunoabinader/servo/dataset = a9d6847 merged ok, testing candidate = 46154fb

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 6, 2014

fast-forwarding master to auto = 46154fb

bors-servo pushed a commit that referenced this pull request Nov 6, 2014
This is a sub-task for #2974.
@bors-servo bors-servo closed this Nov 6, 2014
@bors-servo bors-servo merged commit a9d6847 into servo:master Nov 6, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:dataset branch Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.