Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix README homebrew install regarding glfw3 #3895
Conversation
hoppipolla-critic-bot
commented
Nov 5, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3088 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
I'm confused by this. We don't actually need glfw3 installed since glfw-rs dpeends on glfw-sys which provides one. |
|
Perhaps just remove glfw3 from the list of dependencies? |
|
I have just tested uninstalling glfw3, and the build still appears to work. |
|
@oksome: Want to make this PR remove the dependency, in that case? |
|
Fixed by #3991. |
oksome commentedNov 5, 2014
No description provided.