Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README homebrew install regarding glfw3 #3895

Closed
wants to merge 1 commit into from
Closed

Conversation

@oksome
Copy link

oksome commented Nov 5, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 5, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3088

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack
Copy link
Contributor

metajack commented Nov 5, 2014

I'm confused by this. We don't actually need glfw3 installed since glfw-rs dpeends on glfw-sys which provides one.

@metajack
Copy link
Contributor

metajack commented Nov 5, 2014

Perhaps just remove glfw3 from the list of dependencies?

@oksome
Copy link
Author

oksome commented Nov 8, 2014

I have just tested uninstalling glfw3, and the build still appears to work.

@jdm
Copy link
Member

jdm commented Nov 11, 2014

@oksome: Want to make this PR remove the dependency, in that case?

@jdm jdm mentioned this pull request Nov 15, 2014
@jdm
Copy link
Member

jdm commented Nov 15, 2014

Fixed by #3991.

@jdm jdm closed this Nov 15, 2014
@oksome oksome deleted the oksome:patch-2 branch Nov 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.