XHR - Trigger readystatechange when transitioning from HEADERS_RECEIVED to DONE

[mukilan]

Fixes #3877

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/3108

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[mukilan]

The fix required updating the expectation of several test. I've explained the reasoning below:

/XMLHttpRequest/status-async.htm
--------------------------------
FAIL XMLHttpRequest: status/statusText - various responses 7 (GET 402)
FAIL XMLHttpRequest: status/statusText - various responses 9 (CHICKEN 402)

Both tests read the responseXML, which we do not support yet.

/XMLHttpRequest/anonymous-mode-unsupported.htm
----------------------------------------------
FAIL expected TIMEOUT XMLHttpRequest: anonymous mode unsupported
OK expected TIMEOUT [Parent]

We are not sending document.cookies as of now even for same-origin request. The test expects to find the cookie, otherwise assumes we support anonymous:true and fails.

/XMLHttpRequest/open-after-setrequestheader.htm
-----------------------------------------------
PASS expected TIMEOUT XMLHttpRequest: open() after setRequestHeader()
OK expected TIMEOUT [Parent]

Correct behaviour.

/XMLHttpRequest/response-json.htm
---------------------------------
FAIL JSON object roundtrip
FAIL JSON roundtrip with Japanese text

We recreate the JSON object each time xhr.response is accessed and do not cache it (which is what the test is asserting)

/XMLHttpRequest/send-entity-body-get-head-async.htm
---------------------------------------------------
FAIL expected NOTRUN XMLHttpRequest: send() - non-empty data argument and GET/HEAD - async, no upload events should fire (GET)
FAIL expected NOTRUN XMLHttpRequest: send() - non-empty data argument and GET/HEAD - async, no upload events should fire (HEAD)
OK expected TIMEOUT [Parent]

Before this fix, test.done() was never called. But now since it is called , assert_equal on the event array fails since the test asserts that no "upload" events are fired, while we do. Not sure if this is a bug in the test or in our implementation.

/XMLHttpRequest/send-no-response-event-loadend.htm
--------------------------------------------------
PASS expected TIMEOUT XMLHttpRequest: The send() method: Fire a progress event named loadend (no response entity body)
OK expected TIMEOUT [Parent]

Correct behaviour.

/XMLHttpRequest/send-no-response-event-order.htm
------------------------------------------------
PASS expected TIMEOUT XMLHttpRequest: The send() method: event order when there is no response entity body
OK expected TIMEOUT [Parent]

Correct behaviour

/XMLHttpRequest/status-error.htm
--------------------------------
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 200
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 400
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 401
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 404
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 410
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 500
PASS expected TIMEOUT XMLHttpRequest: status error handling GET 699
PASS expected TIMEOUT XMLHttpRequest: status error handling HEAD 200
PASS expected TIMEOUT XMLHttpRequest: status error handling HEAD 404
PASS expected TIMEOUT XMLHttpRequest: status error handling HEAD 500
PASS expected TIMEOUT XMLHttpRequest: status error handling HEAD 699
PASS expected TIMEOUT XMLHttpRequest: status error handling POST 200
PASS expected TIMEOUT XMLHttpRequest: status error handling POST 404
PASS expected TIMEOUT XMLHttpRequest: status error handling POST 500
PASS expected TIMEOUT XMLHttpRequest: status error handling POST 699
PASS expected TIMEOUT XMLHttpRequest: status error handling PUT 200
PASS expected TIMEOUT XMLHttpRequest: status error handling PUT 404
PASS expected TIMEOUT XMLHttpRequest: status error handling PUT 500
PASS expected TIMEOUT XMLHttpRequest: status error handling PUT 699
OK expected TIMEOUT [Parent]

Correct behaviour.

[Manishearth]

Filed #3919 for the JSON roundtrip thing.

[Manishearth]

r+

[jdm]

@bors: retry

[mukilan]

Filed #3920 for /XMLHttpRequest/send-entity-body-get-head-async.htm

[bors-servo]

saw approval from Manishearth
at mukilan@dc02352

[bors-servo]

merging mukilan/servo/xhr-status-async = dc02352 into auto

[bors-servo]

mukilan/servo/xhr-status-async = dc02352 merged ok, testing candidate = 7f668f2

[bors-servo]

some tests failed:
failure: http://build.servo.org/builders/mac1/builds/104

[bors-servo]

saw approval from Manishearth
at mukilan@dc02352

[bors-servo]

merging mukilan/servo/xhr-status-async = dc02352 into auto

[bors-servo]

mukilan/servo/xhr-status-async = dc02352 merged ok, testing candidate = efac4658

[bors-servo]

some tests failed:
failure: http://build.servo.org/builders/mac1/builds/108

[mukilan]

In the log from buildbot:

 3:05.90 PROCESS_OUTPUT: Thread-TestrunnerManager-1 "invalid http version" (pid:90165 command:/Users/servo/buildbot/slave/mac1/build/target/servo --cpu --hard-fail http://localhost:8000/XMLHttpRequest/status-async.htm)
 3:05.90 PROCESS_OUTPUT: Thread-TestrunnerManager-1 "invalid http version" (pid:90165 command:/Users/servo/buildbot/slave/mac1/build/target/servo --cpu --hard-fail http://localhost:8000/XMLHttpRequest/status-async.htm)
 3:05.90 PROCESS_OUTPUT: Thread-TestrunnerManager-1 "invalid http version" (pid:90165 command:/Users/servo/buildbot/slave/mac1/build/target/servo --cpu --hard-fail http://localhost:8000/XMLHttpRequest/status-async.htm)
 3:05.90 PROCESS_OUTPUT: Thread-TestrunnerManager-1 "invalid http version" (pid:90165 command:/Users/servo/buildbot/slave/mac1/build/target/servo --cpu --hard-fail http://localhost:8000/XMLHttpRequest/status-async.htm)
 3:05.90 PROCESS_OUTPUT: Thread-TestrunnerManager-1 "invalid http version" (pid:90165 command:/Users/servo/buildbot/slave/mac1/build/target/servo --cpu --hard-fail http://localhost:8000/XMLHttpRequest/status-async.htm)
 3:05.90 PROCESS_OUTPUT: Thread-TestrunnerManager-1 "invalid http version" (pid:90165 command:/Users/servo/buildbot/slave/mac1/build/target/servo --cpu --hard-fail http://localhost:8000/XMLHttpRequest/status-async.htm)

What does the "invalid http verison" mean? I cannot reproduce this locally.

[jdm]

r+

[jdm]

@bors: retry

[bors-servo]

saw approval from jdm
at mukilan@504fdbf

[bors-servo]

merging mukilan/servo/xhr-status-async = 504fdbf into auto

[bors-servo]

mukilan/servo/xhr-status-async = 504fdbf merged ok, testing candidate = 125c8c1

[bors-servo]

some tests failed:
failure: http://build.servo.org/builders/linux/builds/567

[bors-servo]

saw approval from jdm
at mukilan@504fdbf

[bors-servo]

merging mukilan/servo/xhr-status-async = 504fdbf into auto

[bors-servo]

mukilan/servo/xhr-status-async = 504fdbf merged ok, testing candidate = 338a9c3

[bors-servo]

all tests pass:
success: http://build.servo.org/builders/linux/builds/568
success: http://build.servo.org/builders/mac1/builds/112
success: http://build.servo.org/builders/mac2/builds/111

[bors-servo]

fast-forwarding master to auto = 338a9c3