Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove libpango linking from linkhack of rust-harfbuzz #393
Conversation
|
I think you forgot to submit the pull request for rust-harfbuzz with the actual change. |
|
Hi, I think we need discuss about how to commit submodules. Actually I have no permission to commit to servo & submodules directly so that I have to do the jobs below. pull request of submodules -> granted -> fix servo to link with newer submodules -> pull request of servo -> granted It seems little bit complex way to contribute to servo.. If.. do you have any idea about this issue, I would be appreciating if you let me know. |
|
@pcwalton and I discussed that updating dependencies should not require review as long as the dependencies have landed. The only part of this we can really eliminate while keeping our review policy is the servo commit. @pcwalton should we add @aydinkim and possibly the other samsung folks to mozilla/servo for this purpose? I assume they could also review code then as well. |
|
It will be great help for us :) |
|
I have fix this now. |
|
Thank you :) |
Mac drivers seem unable to use texel fetch offsets >8. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/393) <!-- Reviewable:end -->
aydinkim commentedApr 22, 2013
Fix #381
I had modified the code at rust-harfbuzz in my local github repository.
I'm sorry that you should cherry-pick my local commit.
or,
Let me know the way to pull request of submodules and servo together.
Thank you.
Aydin Kim