Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove libpango linking from linkhack of rust-harfbuzz #393

Closed
wants to merge 1 commit into from

Conversation

@aydinkim
Copy link

aydinkim commented Apr 22, 2013

Fix #381

I had modified the code at rust-harfbuzz in my local github repository.
I'm sorry that you should cherry-pick my local commit.

or,
Let me know the way to pull request of submodules and servo together.
Thank you.

Aydin Kim

@metajack
Copy link
Contributor

metajack commented Apr 22, 2013

I think you forgot to submit the pull request for rust-harfbuzz with the actual change.

@aydinkim
Copy link
Author

aydinkim commented Apr 23, 2013

Hi,
Sorry for inconvenience.
It is on my local github repo.
aydinkim/rust-harfbuzz@f0402e1

I think we need discuss about how to commit submodules. Actually I have no permission to commit to servo & submodules directly so that I have to do the jobs below.

pull request of submodules -> granted -> fix servo to link with newer submodules -> pull request of servo -> granted

It seems little bit complex way to contribute to servo.. If.. do you have any idea about this issue, I would be appreciating if you let me know.

@metajack
Copy link
Contributor

metajack commented Apr 23, 2013

@pcwalton and I discussed that updating dependencies should not require review as long as the dependencies have landed. The only part of this we can really eliminate while keeping our review policy is the servo commit.

@pcwalton should we add @aydinkim and possibly the other samsung folks to mozilla/servo for this purpose? I assume they could also review code then as well.

@yichoi
Copy link
Contributor

yichoi commented Apr 23, 2013

It will be great help for us :)

@metajack
Copy link
Contributor

metajack commented Apr 23, 2013

I have fix this now.

@metajack metajack closed this Apr 23, 2013
@aydinkim
Copy link
Author

aydinkim commented Apr 23, 2013

Thank you :)

glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Mac drivers seem unable to use texel fetch offsets >8.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/393)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.