Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #84 #3934

Merged
merged 1 commit into from Nov 11, 2014
Merged

Close #84 #3934

merged 1 commit into from Nov 11, 2014

Conversation

@guillaumebort
Copy link
Contributor

guillaumebort commented Nov 7, 2014

Actually <img> elements in <noscript> are not prefetched anymore.

Probably because html5ever already parses the <noscript> content as raw
text data if scripting_enabled is activated.

See https://github.com/servo/html5ever/blob/servo/src/tree_builder/rules.rs#L126

Also, added a test to the images cache.
@guillaumebort
Close #84
Loading status checks…
8e2abb6 
Actually <img> elements in <noscript> are not prefetched anymore.

Probably because html5ever already parses the <noscript> content as raw
text data if `scripting_enabled` is activated.

See
https://github.com/servo/html5ever/blob/servo/src/tree_builder/rules.rs#
L126

Also, added a test to the images cache.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 7, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3113

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@guillaumebort guillaumebort mentioned this pull request Nov 7, 2014
Closed
@jdm
Copy link
Member

jdm commented Nov 11, 2014

Works for me. Thanks!
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 8e2abb6 Nov 11, 2014

saw approval from jdm
at https://github.com/guillaumebort/servo/commit/8e2abb6ffc0521faf001043718110f9baeeb4f40

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 11, 2014

merging guillaumebort/servo/fix/84 = 8e2abb6 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 11, 2014

guillaumebort/servo/fix/84 = 8e2abb6 merged ok, testing candidate = b94f20c

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 11, 2014

all tests pass:
success: http://build.servo.org/builders/linux/builds/591
success: http://build.servo.org/builders/mac1/builds/133
success: http://build.servo.org/builders/mac2/builds/132

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 11, 2014

fast-forwarding master to auto = b94f20c
bors-servo pushed a commit that referenced this pull request Nov 11, 2014
bors-servo
auto merge of #3934 : guillaumebort/servo/fix/84, r=jdm
Loading status checks…
b94f20c 
Actually `<img>` elements in `<noscript>` are not prefetched anymore.

Probably because html5ever already parses the `<noscript>` content as raw
text data if `scripting_enabled` is activated.

See https://github.com/servo/html5ever/blob/servo/src/tree_builder/rules.rs#L126

Also, added a test to the images cache.
@bors-servo bors-servo closed this Nov 11, 2014
@bors-servo bors-servo merged commit 8e2abb6 into servo:master Nov 11, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@guillaumebort @hoppipolla-critic-bot @jdm @bors-servo
You can’t perform that action at this time.