Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #3933 #3938
Fix #3933 #3938
Conversation
hoppipolla-critic-bot
commented
Nov 7, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3119 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
I don't think there's a need to add those fields. Note that @mvanderh is also working on this issue. |
|
Ok you are right, these fields were not needed. I had a look at what @mvanderh was doing and I discovered how This is actually my first look at the servo codebase, so I'm not sure at all of what I'm doing. I let this open for now. |
|
Looking good! I've left one comment on the Critic review. |
|
@jdm ok, I've removed the useless call to |
|
Great! Please squash and I'll merge :) |
|
@jdm Done |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging guillaumebort/servo/fix/3933 = 0976651 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging guillaumebort/servo/fix/3933 = 0976651 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 668d921 |
Implement HTMLOptionElement.{label,value}
Implement HTMLOptionElement.{label,value}
0976651
into
servo:master
guillaumebort commentedNov 7, 2014
Implement HTMLOptionElement.{label,value}