Allow passing arguments to setTimeout/setInterval callbacks

[mukilan]

No description provided.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/3123

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[jdm]

Woah, I didn't expect to see this. Exciting!

[guillaumebort]

Hey,

How does it relate to #3936? I was looking at this issue but I'm not sure if the codegen changes of this pull request magically fix it already? Otherwise how could the argument of SetTimeout be either a DOMString of a Function?

[mukilan]

@guillaumebort : This PR does not implement the SetTimeout(DOMString,...) overload. If you look at the changes in Window.webidl file, you'll see that setTimeout(DOMString, long, any) is commented out. To fix #3936 , we need to uncomment this line. The binding generator will notice that setTimeout has 2 overloads and generate the JS -> Rust binding function (extern fn setTimeout in WindowBinding.rs) such that if the first parameter (i.e argv[0]) is a callable JSObject or function, then the WindowMethods::SetTimeout(Function,...) is invoked or if it is a string, then WindowMethods::SetTimeout(DOMString,...) is invoked, and in all other cases a TypeError is thrown.

[Ms2ger]

(Actually, whenever it's not a callable object, the value is converted to a string.)

[mukilan]

@Ms2ger : My bad. I think it is about time I read the overload resolution algorithm ;-)

[guillaumebort]

Ok great, thanks for the info! I will see if I can apply my pending change on top of your work then.

[Ms2ger]

r+

[Ms2ger]

@bors: retry

• servo#3986

[Ms2ger]

@bors: retry

• servo#3986

[jdm]

@bors: retry

[bors-servo]

saw approval from Ms2ger
at mukilan@4b2b0d0

[bors-servo]

merging mukilan/servo/timeout-arguments = 4b2b0d0 into auto

[bors-servo]

mukilan/servo/timeout-arguments = 4b2b0d0 merged ok, testing candidate = 61705f9

[bors-servo]

saw approval from Ms2ger
at mukilan@4b2b0d0

[bors-servo]

merging mukilan/servo/timeout-arguments = 4b2b0d0 into auto

[bors-servo]

saw approval from Ms2ger
at mukilan@4b2b0d0

[bors-servo]

merging mukilan/servo/timeout-arguments = 4b2b0d0 into auto

[bors-servo]

mukilan/servo/timeout-arguments = 4b2b0d0 merged ok, testing candidate = 43b452f

[bors-servo]

all tests pass:
success: http://build.servo.org/builders/linux/builds/646
success: http://build.servo.org/builders/mac1/builds/188
success: http://build.servo.org/builders/mac2/builds/188

[bors-servo]

fast-forwarding master to auto = 43b452f