Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unused unsafe #396
Merged
Remove unused unsafe #396
+266
−291
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/servo-gfx/text/shaping/harfbuzz.rs in 868c740
Apr 23, 2013
|
Is this not an FFI call? Why isn't unsafe needed here? |
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/servo/dom/bindings/element.rs in 868c740
Apr 23, 2013
|
It similarly freaks me out that we don't need unsafe here. This can totally segfault if given a bad pointer. |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Change packed tiles to use vertex textures, and extend to generic render task data. This is a performance win (by removing all the CPU code that handles batching tiles) and also implements the framework for adding different types of render tasks. For example, a prim cache or blur render task may provide some different data to the shaders than the alpha batcher render task. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/396) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedApr 23, 2013
No description provided.