Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLots of work on bindings #397
Merged
+1,285
−470
Conversation
* Split ClientRect, ClientRectList, and HTMLCollection blobs into separate DOM implementation and binding-related files. * Enforce wrapper initialization at creation time for all DOM objects * Set up the basis for triggering reflow on DOM changes, such as Element.setAttribute * Fix crashes stemming from storing pointers to stack-local AbstractNode objects in DOM node wrappers * Add untested trace hooks for DOM nodes * Implement proper CharacterData inheritance for Text and Comment nodes
…ly query layout. Associate flows with DOM nodes to allow this querying to occur. Alleviate the problem of Element objects not having access to the original AbstractNode by adding a transient field to Node that is non-null while a node downcast is taking place.
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Use an explicit 'subtest' query parameter to select the subtest, instead...
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add basic overlay scrollbar support. This adds the infrastructure for adding scrollbars to any scroll root, however for now it only draws a scrollbar for the root frame. Once we are happy with the implementation and design, we can easily enable it for iframes and other scroll roots. The idea is to insert a primitive of any kind into the primitive tree and tag it as being a scroll bar primitive for a given layer. This means we can allow styling of the scrollbar in the future, making use of any of the display item features that are supported (e.g. border corners, gradients, images, anti-aliasing). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/397) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 23, 2013
DOMParser, some DOM reorganization, wrappers for all nodes at creation time, working GC, first content -> layout queries, etc.