Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Cargo over HTTPS. Fix #3582. #3971

Merged
merged 1 commit into from Nov 13, 2014
Merged

Download Cargo over HTTPS. Fix #3582. #3971

merged 1 commit into from Nov 13, 2014

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 13, 2014

Download from https://static-rust-lang-org.s3.amazonaws.com, which apparently does not require SNI? This bypasses the CloudFront CDN and goes to directly to S3.

CC @brson
@SimonSapin
Download Cargo over HTTPS. Fix #3582.
Loading status checks…
1a684f8
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 13, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3161

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link

Ms2ger commented on 1a684f8 Nov 13, 2014

r+

This comment has been minimized.

Sign in to view
Copy link

larsbergstrom replied Nov 13, 2014

@bors: retry

This comment has been minimized.

Sign in to view
Copy link

jdm replied Nov 13, 2014

@bors: retry
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 1a684f8 Nov 13, 2014

saw approval from Ms2ger
at SimonSapin@1a684f8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

merging SimonSapin/servo/cargo-https = 1a684f8 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

SimonSapin/servo/cargo-https = 1a684f8 merged ok, testing candidate = f863adf

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

saw approval from Ms2ger
at SimonSapin@1a684f8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

merging SimonSapin/servo/cargo-https = 1a684f8 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

saw approval from Ms2ger
at SimonSapin@1a684f8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

merging SimonSapin/servo/cargo-https = 1a684f8 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

SimonSapin/servo/cargo-https = 1a684f8 merged ok, testing candidate = 8cb2b92

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

all tests pass:
success: http://build.servo.org/builders/linux/builds/610
success: http://build.servo.org/builders/mac1/builds/152
success: http://build.servo.org/builders/mac2/builds/151

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Nov 13, 2014

fast-forwarding master to auto = 8cb2b92
bors-servo pushed a commit that referenced this pull request Nov 13, 2014
bors-servo
auto merge of #3971 : SimonSapin/servo/cargo-https, r=Ms2ger
f863adf 
Download from https://static-rust-lang-org.s3.amazonaws.com, which apparently does not require SNI? This bypasses the CloudFront CDN and goes to directly to S3.

CC @brson
bors-servo pushed a commit that referenced this pull request Nov 13, 2014
bors-servo
auto merge of #3971 : SimonSapin/servo/cargo-https, r=Ms2ger
Loading status checks…
e8cbf1e 
Download from https://static-rust-lang-org.s3.amazonaws.com, which apparently does not require SNI? This bypasses the CloudFront CDN and goes to directly to S3.

CC @brson
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 13, 2014 

Ran 145253 tests (1122 parents, 144131 subtests)
Expected results: 145177
Unexpected results: 1 (CRASH: 1)
Skipped: 75

Unexpected Results
==================

/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/setting-postMessage.html
-----------------------------------------------------------------------------------
CRASH [Parent]
 8:13.65 LOG: MainThread INFO Closing logging queue
bors-servo pushed a commit that referenced this pull request Nov 13, 2014
bors-servo
auto merge of #3971 : SimonSapin/servo/cargo-https, r=Ms2ger
Loading status checks…
8cb2b92 
Download from https://static-rust-lang-org.s3.amazonaws.com, which apparently does not require SNI? This bypasses the CloudFront CDN and goes to directly to S3.

CC @brson
@bors-servo bors-servo closed this Nov 13, 2014
@bors-servo bors-servo merged commit 1a684f8 into servo:master Nov 13, 2014
1 check passed
1 check passed
default all tests passed
@SimonSapin SimonSapin deleted the SimonSapin:cargo-https branch Nov 14, 2014
@SimonSapin SimonSapin mentioned this pull request Nov 12, 2015
Merged
SimonSapin added a commit that referenced this pull request Jul 7, 2016
@SimonSapin
Fix "looking for rustc at …" message for stable when already bootstra…
4b90347 
…pped

Also always download from static-rust-lang-org.s3.amazonaws.com instead
of static.rust-lang.org. They host the same content, but the latter goes
through a CDN and has a TLS certificate that failed to verify and some
Python versions:

#3582
#3971
SimonSapin added a commit that referenced this pull request Jul 8, 2016
@SimonSapin
Fix "looking for rustc at …" message for stable when already bootstra…
ae778e0 
…pped

Also always download from static-rust-lang-org.s3.amazonaws.com instead
of static.rust-lang.org. They host the same content, but the latter goes
through a CDN and has a TLS certificate that failed to verify and some
Python versions:

#3582
#3971
SimonSapin added a commit that referenced this pull request Jul 8, 2016
@SimonSapin
Fix "looking for rustc at …" message for stable when already bootstra…
6ae5598 
…pped

Also always download from static-rust-lang-org.s3.amazonaws.com instead
of static.rust-lang.org. They host the same content, but the latter goes
through a CDN and has a TLS certificate that failed to verify and some
Python versions:

#3582
#3971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @hoppipolla-critic-bot @larsbergstrom @bors-servo @jdm @Ms2ger
You can’t perform that action at this time.