Repository navigation
xpath: Cast query result to desired type - #39764
Merged
Merged
Conversation
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55351) with upstreamable changes. |
simonwuelker
force-pushed
the
xpath-result-cast
branch
from
October 10, 2025 17:27
e37f0cf to
00041b8
Compare
Collaborator
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#55351). |
simonwuelker
force-pushed
the
xpath-result-cast
branch
2 times, most recently
from
October 11, 2025 18:42
5c2effc to
242762d
Compare
jdm
approved these changes
Oct 12, 2025
simonwuelker
force-pushed
the
xpath-result-cast
branch
from
October 12, 2025 11:05
242762d to
98ec931
Compare
simonwuelker
enabled auto-merge
October 12, 2025 11:05
simonwuelker
force-pushed
the
xpath-result-cast
branch
from
October 13, 2025 08:59
98ec931 to
9acbac3
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2025
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
xpath-result-cast
branch
from
October 13, 2025 10:41
9acbac3 to
00c3593
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running an XPath query, users supply a target result type (eg
XPathResult.NUMBER_TYPE). When this type does match the return value of the query, then we need to convert to it.See https://searchfox.org/firefox-main/rev/ab5bf2401717970560597083d6ac72915bde2d89/dom/xslt/xpath/XPathResult.cpp#160 for the relevant part in gecko.
Testing: This change adds a test
Part of #34527