Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix ABI incompatibility problem of some JS direct-connected API #398
Conversation
|
I'm willing to commit this for now (after a rebase that clears up the new places that also use JS_GetReservedSlot), but these adhoc changes worry me. We need to sit down and figure out whether we need to wrap all of the relevant JSAPI calls or find some other solution. |
|
Ping? Is this going to get rebased, or is it no longer needed? |
|
We discussed this today, and we believe that a much less intrusive fix is possible. If we define JSVal as a struct containing a u64 in jsapi.rs, that should cause rustc to use the correct calling convention on ARM. Could you try that fix instead? |
|
@jdm What a clever and neat idea!!! |
|
We have been thinking 2 transitional ideas: one is wrapping with struct like jdm mentioned and the other is a kind of unsafe enum. I agree to struct approach for this issue but I want to know whether there is really general solution on rust side or not. |
|
I'm working on this on my rust-mozjs branch and servo branch. |
|
Yes, that looks right to me. |
|
+1 |
|
@jdm thinks you for your comments. |
Add more tests for Proximity Events
Implement GetShaderInfoLog, GetProgramInfoLog and ValidateProgram <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/398) <!-- Reviewable:end -->
aydinkim commentedApr 24, 2013
As you know, there is a issue when connect rust to c(++) between another ABIs.
So I added some glue code to use JS API normally regardless of ABI difference.
I had also modified the module : rust-mozjs
actual commit is on my local github.
aydinkim/rust-mozjs@35c7752
and the source code diff is attached below.
https://gist.github.com/aydinkim/5450506