Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use freetype-sys on Linux. #3980

Merged
merged 2 commits into from Nov 15, 2014
Merged

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 14, 2014

See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114

Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.

r? @larsbergstrom

See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114

Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Nov 14, 2014

Critic review: https://critic.hoppipolla.co.uk/r/3167

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@larsbergstrom

This comment has been minimized.

Copy link

larsbergstrom commented on b1eb403 Nov 14, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on b1eb403 Nov 14, 2014

saw approval from larsbergstrom
at SimonSapin@b1eb403

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 14, 2014

merging SimonSapin/servo/freetype-sys-linux = b1eb403 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 14, 2014

SimonSapin/servo/freetype-sys-linux = b1eb403 merged ok, testing candidate = 617e32b

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 14, 2014

bors-servo pushed a commit that referenced this pull request Nov 14, 2014
…strom

See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114

Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.

r? @larsbergstrom
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 14, 2014

So freetype-sys defaults to using bzip2, which the builders current don’t have installed. We can make this a new requirement, or compile with:

libfreetype2% ./configure --help | grep bz
  --without-bzip2         do not support bzip2 compressed fonts

But I have no idea how common bzip2 compressed fonts are.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 14, 2014

I suspect we'll have to support it - from random googling, Ubuntu Linux appears to like to ship bzip2 compressed fonts. I guess I'll have to add the package to the builders and we should add a note to the readme about installing the correct package.

… but not for Homebrew or MacPorts, OS X which apparently ships with it.
@larsbergstrom

This comment has been minimized.

Copy link

larsbergstrom commented on ed9e307 Nov 14, 2014

r+

This comment has been minimized.

Copy link

mbrubeck replied Nov 14, 2014

@bors: retry

This comment has been minimized.

Copy link
Owner Author

SimonSapin replied Nov 15, 2014

@bors: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on ed9e307 Nov 14, 2014

saw approval from larsbergstrom
at SimonSapin@ed9e307

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 14, 2014

merging SimonSapin/servo/freetype-sys-linux = ed9e307 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 14, 2014

SimonSapin/servo/freetype-sys-linux = ed9e307 merged ok, testing candidate = e9322bb

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 14, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

saw approval from larsbergstrom
at SimonSapin@ed9e307

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

saw approval from larsbergstrom
at SimonSapin@ed9e307

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

merging SimonSapin/servo/freetype-sys-linux = ed9e307 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

SimonSapin/servo/freetype-sys-linux = ed9e307 merged ok, testing candidate = 644765e

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Nov 15, 2014

fast-forwarding master to auto = 644765e

bors-servo pushed a commit that referenced this pull request Nov 14, 2014
…strom

See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114

Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.

r? @larsbergstrom
@jdm
Copy link
Member

jdm commented Nov 14, 2014

task '<main>' panicked at 'assertion failed: `(left == right) && (right == left)` (left: `https://github.com/servo/green-rs?ref=servo`, right: `https://github.com/alexcrichton/green-rs#215f3c87`)', src/cargo/core/dependency.rs:130

@mbrubeck, this PR hit that when compiling cef, and zmike hit it locally as well. Any thoughts?

@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 14, 2014

I think the cargo panic may be fixed by #3985.

bors-servo pushed a commit that referenced this pull request Nov 15, 2014
…strom

See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114

Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.

r? @larsbergstrom
bors-servo pushed a commit that referenced this pull request Nov 15, 2014
…strom

See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114

Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.

r? @larsbergstrom
@bors-servo bors-servo closed this Nov 15, 2014
@bors-servo bors-servo merged commit ed9e307 into servo:master Nov 15, 2014
1 check passed
1 check passed
default all tests passed
@SimonSapin SimonSapin deleted the SimonSapin:freetype-sys-linux branch Nov 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.