Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse freetype-sys on Linux. #3980
Conversation
See: servo/libfreetype2#2 servo/skia#38 servo/rust-azure#114 Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.
hoppipolla-critic-bot
commented
Nov 14, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/3167 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on b1eb403
Nov 14, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/freetype-sys-linux = b1eb403 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
…strom See: servo/libfreetype2#2 servo/skia#38 servo/rust-azure#114 Let’s close #3867, even though this only works around and doesn’t fix the underlying issue. r? @larsbergstrom
|
So freetype-sys defaults to using bzip2, which the builders current don’t have installed. We can make this a new requirement, or compile with:
But I have no idea how common bzip2 compressed fonts are. |
|
I suspect we'll have to support it - from random googling, Ubuntu Linux appears to like to ship bzip2 compressed fonts. I guess I'll have to add the package to the builders and we should add a note to the readme about installing the correct package. |
… but not for Homebrew or MacPorts, OS X which apparently ships with it.
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on ed9e307
Nov 14, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
mbrubeck
replied
Nov 14, 2014
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/freetype-sys-linux = ed9e307 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
saw approval from larsbergstrom |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/freetype-sys-linux = ed9e307 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 644765e |
…strom See: servo/libfreetype2#2 servo/skia#38 servo/rust-azure#114 Let’s close #3867, even though this only works around and doesn’t fix the underlying issue. r? @larsbergstrom
@mbrubeck, this PR hit that when compiling cef, and zmike hit it locally as well. Any thoughts? |
|
I think the cargo panic may be fixed by #3985. |
…strom See: servo/libfreetype2#2 servo/skia#38 servo/rust-azure#114 Let’s close #3867, even though this only works around and doesn’t fix the underlying issue. r? @larsbergstrom
…strom See: servo/libfreetype2#2 servo/skia#38 servo/rust-azure#114 Let’s close #3867, even though this only works around and doesn’t fix the underlying issue. r? @larsbergstrom
ed9e307
into
servo:master
SimonSapin commentedNov 14, 2014
See:
servo/libfreetype2#2
servo/skia#38
servo/rust-azure#114
Let’s close #3867, even though this only works around and doesn’t fix the underlying issue.
r? @larsbergstrom