libservo: Rename WebView::set_pinch_zoom to WebView::pinch_zoom - #39868
Merged
Merged
Conversation
This change is meant to make it more obvious that adjusting the pinch zoom of a `WebView` works differently than adjusting the page zoom. New pinch zoom values are *always* zoom deltas, that is they are always multiplied by the current pinch zoom value. This is due to the way that system APIs and Servo's internal touch handler provide values. In addition, stop clamping the pinch zoom by the page zoom clamp values. They aren't meant for that. Instead set up some reasonable clamping values for pinch zoom in the compositor. Also add more rustdoc for public API. Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
atbrakhi
approved these changes
Oct 14, 2025
servo-highfive
removed
the
S-awaiting-review
atbrakhi
enabled auto-merge
October 14, 2025 14:34
yezhizhen
reviewed
Oct 14, 2025
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
Author
Good point. We should consider a new name. |
kongbai1996
reviewed
Nov 4, 2025
| } | ||
|
|
||
| fn set_pinch_zoom_level(&mut self, mut zoom: f32) -> bool { | ||
| if let Some(viewport) = self.viewport_description.as_ref() { |
Contributor
There was a problem hiding this comment.
Incorrect deletion logic; it should be restricted using self.viewport_description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is meant to make it more obvious that adjusting the pinch
zoom of a
WebViewworks differently than adjusting the page zoom.New pinch zoom values are always zoom deltas, that is they are always
multiplied by the current pinch zoom value. This is due to the way that
system APIs and Servo's internal touch handler provide values.
In addition, stop clamping the pinch zoom by the page zoom clamp values.
They aren't meant for that. Instead set up some reasonable clamping
values for pinch zoom in the compositor.
Also add more rustdoc for public API.
Testing: The changes to API naming do not really need tests, and the changes to
behavior (the clamping) can't be easily tested now as there is no way currently
to read the current pinch zoom level of the WebView. This requires more API in
the renderer.